Look for errors in the graphql response for metric tagging #2162
+135
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjacobs44
requested review from
paulbakker,
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross and
iparadiso
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
It's possible to manually craft a
DataFetcherResultand place errors within the error field. In the previous implementation, if your datafetcher were to catch all of its own exceptions and do this manual creation of aDataFetcherResult, those requests would not properly get tagged as a request which contained an error in metrics.This changes the implementation to inspect the actual graphql result to check if it contains errors on top of just looking for exceptions.