Skip to content

fixes remediation naming case #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes remediation naming case #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a36cfd
fixes remediation naming case
sbehrens Jan 14, 2019
091f5d8
fixed case issue with confidence level
sbehrens Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/helpers/vulnerability_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def self.open_statuses
end

def self.closed_statuses
["ignored", "false positive", "remediated", "risk accepted"]
["ignored", "false positive", "Remediated", "risk accepted"]
end


Expand Down Expand Up @@ -220,7 +220,7 @@ def update_vulnerabilities(vulnerabilities=[], save_result=true, update_counts=t
# For any closed statuses except remediated we'll do nothing
# If it's remediated we want to reopen the vulnerability
# If it's already open we want to update the status to reflect whether there is a ticket
if(!Vulnerability.closed_statuses.except("remediated").include?(r["status"].to_s.downcase))
if(!Vulnerability.closed_statuses.except("Remediated").include?(r["status"].to_s.downcase))
if(r["jira_ids"].present?)
r["status"] = "Ticketed"
else
Expand Down
2 changes: 1 addition & 1 deletion lib/scumblr_tasks/security/python_analyzer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def perform_work(result_id)
vuln.match_location = "source_code"
end

vuln.confidence_level = issue["issue_confidence"].to_s
vuln.confidence_level = issue["issue_confidence"].to_s.lower().capitalize()
vuln.severity = issue["issue_severity"].to_s
vuln.source = "Bandit"

Expand Down