Spelling #107
Spelling #107
Conversation
|
Hi Jsoref, We've done a bunch of code changes since the 1.0 release. Any way you could run your spellchecker against the new code as well? |
|
@sbehrens: Here's a set of fixes for things which were visibly misspelled as identified in insertions/removals between when I branched off. |
| # Many of these configuration options can be set straight in your model. | ||
| Devise.setup do |config| | ||
| #allows devise to use mutal TLS for auth | ||
| #allows devise to use mutual TLS for auth |
There was a problem hiding this comment.
I'm not sure if this is the correct fix -- I don't have enough context.
|
|
||
| if response.nil? | ||
| @retry_interavl = 0 | ||
| @retry_interval = 0 |
There was a problem hiding this comment.
This series @retry_interavl is an actual bug as opposed to just a typo in a comment or a consistently misspelled api.
|
Nice, thanks again. Would be interested in you checking some of our other security tools using your spelling scripts: https://github.com/netflix/sketchy and https://github.com/netflix/sleepy-puppy if you are willing to help! |
|
I can, but at some point, you're going to need to update lodash. They misspelled |
|
Thanks for taking these PRs. FWIW, this output is manual, I have a script which lists tokens that it doesn't recognize as words, and then it's up to me to decide based on what's left which things are typos and which are ok. (And I'm not perfect.) Some stats:
Because everything after the first column is manual (I do have a tool to sort the PRs alphabetically, although it looks like I didn't necessarily run it for some of these), it isn't a guarantee there aren't other errors. -- While trying to build this table, I found two that I had missed. |
2 participants
This is a series of spelling fixes to Scumblr (including one for misspelling the product name...).
This PR can, of course, be folded together. However, initially, it is much easier to rebase and discuss individual concepts as individual commits. It's also possible to split this PR into a couple, one for API changes and one for other things, but there aren't many such items in this PR and I'd rather not spend that time on it.