Skip to content

Small code quality fixups #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

Small code quality fixups #2164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acd5180
getzones: normalise formatting
cheesestraws May 13, 2025
d49ec6e
nbplkup: put loose unicode include where it belongs with the other li…
cheesestraws May 14, 2025
08128dd
pap: remove unconditional conditional
cheesestraws May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions bin/getzones/getzones.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ static void usage(char *s)

int main(int argc, char *argv[])
{
struct atp_handle *ah;
struct atp_block atpb;
struct sockaddr_at saddr;
struct servent *se;
char reqdata[4], buf[ATP_MAXDATA];
struct iovec iov;
short temp, index = 0;
int c, myzoneflg = 0, localzonesflg = 0, errflg = 0;
extern int optind;
struct atp_handle *ah;
struct atp_block atpb;
struct sockaddr_at saddr;
struct servent *se;
char reqdata[4], buf[ATP_MAXDATA];
struct iovec iov;
short temp, index = 0;
int c, myzoneflg = 0, localzonesflg = 0, errflg = 0;
extern int optind;
reqdata[0] = ZIPOP_GETZONELIST;

while ((c = getopt(argc, argv, "ml")) != EOF) {
Expand Down
4 changes: 1 addition & 3 deletions bin/nbp/nbplkup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,13 @@
#include <netatalk/endian.h>
#include <netatalk/at.h>
#include <atalk/nbp.h>
#include <atalk/unicode.h>
#include <atalk/util.h>
#include <string.h>
#include <stdbool.h>
#include <stdio.h>
#include <stdlib.h>


#include <atalk/unicode.h>

#define MACCHARSET "MAC_ROMAN"

static char *Obj = "=";
Expand Down
8 changes: 0 additions & 8 deletions bin/pap/pap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#include <string.h>
#include <stdlib.h>

#define FUCKED

#define _PATH_PAPRC ".paprc"

#define IMAGEWRITER "ImageWriter"
Expand Down Expand Up @@ -172,16 +170,13 @@ int main(int ac, char **av)

while ((c = getopt(ac, av, "dWwcep:s:EA:")) != EOF) {
switch (c) {
#ifdef FUCKED

case 'w' :
waitforprinter = 1;
break;

case 'W' :
waitforidle = 1;
break;
#endif /* FUCKED */

/* enable debugging */
case 'd' :
Expand Down Expand Up @@ -932,8 +927,6 @@ static int send_file(int fd, ATP atp, int lastfile, int is_imagewriter)
printf("< STATUS\n"), fflush(stdout);
}

#ifdef FUCKED

if (waitforprinter) {
char st_buf[1024]; /* XXX too big */
memcpy(st_buf, (char *) rniov[0].iov_base + 9,
Expand All @@ -945,7 +938,6 @@ static int send_file(int fd, ATP atp, int lastfile, int is_imagewriter)
}
}

#endif /* FUCKED */
updatestatus((char *) rniov[0].iov_base + 9,
((char *)rniov[0].iov_base)[8]);
}
Expand Down