Skip to content

Conversation

@recursivetree
Copy link

@recursivetree recursivetree commented Oct 1, 2025

This PR is up here to share the code for code review.

See https://mail-index.netbsd.org/port-arm/2025/09/27/msg009420.html and following messages

@recursivetree recursivetree force-pushed the armv5-fdt-upstreamable-v2 branch from 867e5e9 to e954eec Compare October 3, 2025 20:06
@recursivetree
Copy link
Author

  • changed CPU_PRE_ARMV6 to defined(_ARM_ARCH_5)
  • fixed merge conflicts

netbsd-srcmastr pushed a commit that referenced this pull request Oct 19, 2025
	lib/libc/gen/ctype.3: revision 1.34
	lib/libc/gen/ctype.3: revision 1.35

ctype(3): Clarify test program output.  Update compiler warning.

Should be a little easier to read.  The fact that isprint returns
_any_ nonzero value, not necessarily 1, isn't germane to the point
here, so showing it return 5 or 2 doesn't really help to illustrate
anything.


ctype(3): Fix versions and clarify what LIBC_ALLOWCTYPEABUSE does.

Both the extra diagnostics _and_ LIBC_ALLOWCTYPEABUSE are new in 11.

The extra diagnostics were not added in 10 (unless someone went ahead
and pulled them up while I wasn't looking!).
LIBC_ALLOWCTYPEABUSE doesn't guarantee that the program won't crash;
it just makes that depend on factors such as address space layout
randomization -- where the ctype tables appear in memory relative to
non-readable pages.

PR lib/58208: ctype(3) provides poor runtime feedback of abuse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant