tee: syscall return values #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mknos
commented
Jul 25, 2024
mknos
commented
- Consistently check return val of syscalls open()/read()/write()/close() for -1 instead of sometimes checking for -1 and sometimes checking for <1
- The OpenBSD version already follows this pattern
- Also remove getopt switch case for "tee -?"; the default case is good enough for printing usage string
* Consistently check return val of syscalls open()/read()/write()/close() for -1 instead of <1 * The OpenBSD version already follows this pattern * While here, remove switch case for -?; the default case is good enough for printing usage string
netbsd-srcmastr
pushed a commit
that referenced
this pull request
Oct 1, 2025
external/apache2/mDNSResponder/dist/mDNSPosix/PosixDaemon.c: revision 1.20 PR/58778: mDNS spams console with recent build Default to logging off. OK christos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.