Skip to content

feat(rn): 增加css中对百分比单位的支持 #17314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yinone
Copy link

@yinone yinone commented Feb 13, 2025

这个 PR 做了什么? (简要描述所做更改)

react-native@0.76.1版本中已经支持了transform值为百分比单位的特性,这个PR也同步添加对该功能的支持

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Summary by CodeRabbit

  • 测试

    • 增加了新测试用例,确保基于百分比的样式转换能正确执行。
    • 优化了错误信息格式和调用方式,提升了测试的清晰度和一致性。
  • 重构

    • 改进了样式转换处理逻辑,实现了对混合数值类型(包括百分比)的更灵活支持。

This was referenced Feb 15, 2025
Copy link

coderabbitai bot commented Apr 8, 2025

"""

Walkthrough

此次提交主要增加了 transform 函数的测试覆盖面,新增了针对 CSS 中 translateXtranslateY 百分比值转换的测试用例,并对部分现有测试进行了格式化和错误信息的改进。同时,对 transform.js 文件中的 token 类型处理进行了调整:新增了 PERCENT token 类型,并更新了相关函数(如 oneOfTypexyTransformFactory)以接受数组形式的 token 类型,从而使解析逻辑更加灵活。

Changes

文件路径 更改摘要
packages/css-to-react-native/**/tests/index.spec.js 新增对 CSS translateXtranslateY 百分比值转换的测试用例;调整函数调用格式(使用括号包裹多行字符串);更新错误信息格式,提高了一致性与可读性。
packages/css-to-react-native/**/transforms/transform.js 添加 PERCENT token 类型;更新 oneOfTypexyTransformFactory 以接受数组形式的 token 类型;修改常量定义(如 singleLengthxyNumberxyLengthxyAngle)以支持多 token 类型解析。

Sequence Diagram(s)

sequenceDiagram
    participant TS as 测试套件
    participant TF as transform函数
    participant TP as Token解析器

    TS->>TF: 提供包含百分比值的CSS字符串
    TF->>TP: 调用 oneOfType([LENGTH, PERCENT]) 解析 translateX/Y 值
    TP-->>TF: 返回解析后的token
    TF-->>TS: 返回转换后的输出对象
Loading

Suggested reviewers

  • Single-Dancer

Poem

我是一只快乐的小兔子,
跳跃在代码的花园里,
测试增新香气扑鼻,
错误信息变得优雅明晰,
转换逻辑仿若春风,轻拂每一字节!
🐇✨🌸
"""

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f08e33 and 0119c96.

📒 Files selected for processing (1)
  • packages/css-to-react-native/__tests__/index.spec.js (16 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/css-to-react-native/tests/index.spec.js
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced Apr 12, 2025
@coderabbitai coderabbitai bot requested a review from Single-Dancer May 22, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant