Feat: Enable giscus comments #811
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the necessary configuration to allow visitors to comment on venues.
Deploying website with
|
| Latest commit: |
91f2aa5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37b7261e.website-b3u.pages.dev |
| Branch Preview URL: | https://enable-giscus.website-b3u.pages.dev |
Snippet that will be used at the footer of pages to display comments, and the UI to add comments.
In theory this should add the giscus snippet to the bottom of pages.
Switch to using pathname rather than URL for discussion topic
Contributor
Author
|
@darkling WDYT?
One gotcha is that the GitHub discussion threads end up with the duplicate content as the top post, "A global map of places to visit that might appeal to nerdy types" and the URL to the page. I'm not sure how much of a pain that is, as I imagine most "normies" will be leaving comments on the website itself, not here in the discussions tab on GitHub. 🤷 Also, people who do browse the discussions page on GitHub will see all discussions from us, and all the ones originating under venue pages. However, it's possible to filter those out with this: https://github.com/NerdyDayTrips/website/discussions?discussions_q=is%3Aopen+-category%3AVenues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary configuration to allow visitors to comment on venues.
Visitors will need a GitHub account.