Refuse connection bad timestamp #737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the peer that the connection is made with reports another timestamp in the handshake, then the connection is refused. This change is made because it disallows a DOS'er to reuse the handshake. More DOS protection should of course be made but this is already a step in the right direction. The limit is set to 90 seconds which should be enough on even bad connections. This limit is in the same order of magnitude as the standard timeout of a TCP connection, 72 seconds on Windows. https://serverfault.com/questions/193160/which-is-the-default-tcp-connect-timeout-in-windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refuse connection if peer reports a timestamp that's 90 seconds different from ours.
Previously only a warning was logged but the network has seen some light DOS, and this disallows the reuse of the handshake, so I consider it a step in the right direction.