feat: mining-state-machine, display inactive reasons #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes Neptune-Crypto#423 implements a custom finite-state-machine that processes events in the mining loop and handles state-transitions. benefits/reasons: 1. Simplify the complex code in the mining loop so it is more maintainable. 2. move towards a lock-free mining loop, which means less possibility of delay for miners. 3. Cleanly support granular display of mining-status, so user can see a message like "waiting for block proposal" rather than just "inactive". 4. consolidate/unify pause and unpause logic, since pausing can occur for different reasons. 5. Make the core logic of transitioning between mining states testable via unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR for now. I will add some screenshots and notes later.
closes #423
implements a custom finite-state-machine that processes events in the mining loop and handles state-transitions.
benefits/reasons:
Simplify the complex code in the mining loop so it is more maintainable.
move towards a lock-free mining loop, which means less possibility of delay for miners.
Cleanly support granular display of mining-status, so user can see a message like "waiting for block proposal" rather than just "inactive".
consolidate/unify pause and unpause logic, since pausing can occur for different reasons.
Make the core logic of transitioning between mining states testable via unit tests.