Skip to content

Rename 5-arg Base.view methods #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Conversation

lgoettgens
Copy link
Collaborator

Resolves #2065.

I added a to be activated deprecation

Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.11%. Comparing base (542a6be) to head (8a39d6d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Deprecations.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2071      +/-   ##
==========================================
- Coverage   88.14%   88.11%   -0.03%     
==========================================
  Files         100      100              
  Lines       36852    36853       +1     
==========================================
- Hits        32482    32473       -9     
- Misses       4370     4380      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens merged commit 7695876 into Nemocas:master May 8, 2025
24 of 25 checks passed
@lgoettgens lgoettgens deleted the lg/view-5-arg branch May 15, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5-arg methods of Base.view don't satisfy documentation
2 participants