-
Notifications
You must be signed in to change notification settings - Fork 488
feat(authorization): skip undefined/empty query parameter #4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(authorization): skip undefined/empty query parameter #4124
Conversation
fd2f182
to
f97243c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any risk to always remove them?
I was thinking about that, but I’m concerned it might be a breaking change for some. What do you think, should we omit empty query params entirely for all? |
I guess it could be 😞 lets go with that then 👍🏻 |
…complete-removal-of-scope-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we always skip the empty params? regarless of the provider and then avoid having to add yet another option to provider.yaml?
asked the same but in retrospect I'm sure some are relying on this unfortunately |
…complete-removal-of-scope-params
Describe the problem and your solution
scope
which we automatically inject.authorization_url_skip_undefined
that can be set totrue
for providers where we want to omit these undefined parameters from the authorization URL.This PR introduces a new boolean configuration flag,
authorization_url_skip_empty
, to provider definitions, enabling selective omission of query parameters with empty or undefined values from OAuth authorization URLs. The update addresses cases where some providers (e.g., Dropbox Sign) reject URLs containing such parameters (likescope
) when they're empty, enhancing compatibility with strict provider requirements.Key Changes:
• Added
authorization_url_skip_empty?: boolean
to provider type definitions (provider.ts
)• Extended provider JSON schema (
schema.json
) to include the new flag• Updated OAuth controller logic (
oauth.controller.ts
) to remove empty string query parameters from the authorization URL when the flag is enabledAffected Areas:
• OAuth controller logic
• Provider configuration schema validation
• Provider TypeScript interface definitions
This summary was automatically generated by @propel-code-bot