feat(integrations): add support for PreciseFP #3975
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
docs-v2/mint.json
Outdated
| @@ -697,6 +697,7 @@ | |||
| "integrations/all/wakatime", | |||
| "integrations/all/wave-accounting", | |||
| "integrations/all/wealthbox", | |||
| "integrations/all/precisefp", | |||
There was a problem hiding this comment.
Integration entry not in alphabetical order
| token_url: https://app.precisefp.com/oauth/token | ||
| authorization_params: | ||
| response_type: code | ||
| scope: "*" |
There was a problem hiding this comment.
Using wildcard scope "*" requests excessive permissions
There was a problem hiding this comment.
This is specified in their documentation
| method: GET | ||
| endpoints: | ||
| - /api/v3/user | ||
| docs: https://docs.nango.dev/integrations/all/precisefp |
There was a problem hiding this comment.
No rate limit configuration specified for the API
| | Security audit | ❓ | | | ||
|
|
||
|
|
||
| ## Setup guide |
There was a problem hiding this comment.
Setup guide section is empty despite PR description mentioning 'Added PreciseFP provider configuration in providers.yaml'
| <Note>Contribute useful links by [editing this page](https://github.com/nangohq/nango/tree/master/docs-v2/integrations/all/precisefp.mdx)</Note> | ||
|
|
||
| ## API gotchas | ||
| - To implement OAuth for your application, you must be issued API credentials first. Please reach out to PreciseFP to get your API credentials (Client ID and Client Secret). |
There was a problem hiding this comment.
Missing contact information or process for obtaining API credentials
| ## API gotchas | ||
| - To implement OAuth for your application, you must be issued API credentials first. Please reach out to PreciseFP to get your API credentials (Client ID and Client Secret). | ||
| - Once you have your API credentials (Client ID and Client Secret), you are ready to start implementing the OAuth Authorization. | ||
| - The scope of access should always be "*". |
There was a problem hiding this comment.
Wildcard scope requirement mentioned without security implications or explanation
| | Pre-Requisites | Status | Comment| | ||
| | - | - | - | | ||
| | Paid dev account | ✅ | You need API credentials (Client ID and Client Secret) | | ||
| | Paid test account | ❓ | | |
There was a problem hiding this comment.
Multiple fields in the access requirements table use '❓' without explanation, leaving users uncertain about requirements
|
Thank you for the feedback! I have addressed all the issues:
|
|
Regarding the wildcard scope "*": This is specifically required by PreciseFP as their only accepted scope value. I have added an explanation in the API gotchas section to clarify this requirement. |
|
I have added rate limit configuration to the provider with 60 requests per minute as specified in the PreciseFP API documentation. |
|
I have added a complete setup guide with detailed steps for obtaining API credentials and configuring OAuth in Nango. |
|
I have updated the access requirements table with proper values (✅/❌) and added explanations where needed. |
There was a problem hiding this comment.
the svg seems invalid
| rate_limit: | ||
| rate: 60 | ||
| period: 60 |
There was a problem hiding this comment.
This rate limit configuration doesn't exist on our side
| rate_limit: | |
| rate: 60 | |
| period: 60 |
|
I have fixed the logo issue by replacing the invalid PNG file (with SVG extension) with a proper SVG file that uses the PreciseFP brand colors. |
TBonnin
force-pushed
the
master
branch
3 times, most recently
from
f519537 to
87a5092
Compare
This PR adds support for PreciseFP OAuth integration.
Summary by mrge
Added PreciseFP as a new OAuth integration, including provider configuration, documentation, and logo.