Skip to content

Remove expired links in Dublin LiDAR record alert #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Remove expired links in Dublin LiDAR record alert #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a464a17
Remove expired links in Dublin LiDAR record alert
Sep 20, 2024
5058af0
Updating show_page test to reflect expected changes in LiDAR alert
Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions app/views/catalog/_laefer_notice.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
<div class="alert alert-warning alert-dismissible" role="alert">
<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span>
</button>
Thank you for your interest in data from the <%= link_to search_catalog_path({f: {"#{Settings.FIELDS.PART_OF}" => ['2015 Dublin LiDAR']}}) do %><b>2015 Dublin LiDAR</b><% end %> project.<br><br>
We would appreciate your feedback on this unique dataset. Please take a moment to fill out <a href="https://nyu.qualtrics.com/jfe/form/SV_42ddIXjT0CtaqAR" target="_blank">this brief survey</a> telling us a little bit about yourself, how you found the data, and how you are using it.
Having an accurate idea of how users are accessing and using the data is essential to being able to produce datasets of this magnitude.<br><br>
For a better sense of what this data looks like in 3D, please refer to <a href="https://youtu.be/qEi2Wo7Bcuk">this video flythrough</a> of a portion of the covered area.<br><br>Please cite this study using the DOI: <code><a href="https://doi.org/10.17609/N8MQ0N">doi:10.17609/N8MQ0N</a></code>
Thank you for your interest in data from the 2015 Dublin LiDAR project.<br><br>
For a better sense of what this data looks like in 3D, please refer to <a href="https://youtu.be/qEi2Wo7Bcuk">this video flythrough</a> of a portion of the covered area.<br><br>
Please cite this study using the DOI: <code><a href="https://doi.org/10.17609/N8MQ0N">doi:10.17609/N8MQ0N</a></code>
</div>
11 changes: 3 additions & 8 deletions spec/features/show_page_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,16 @@
expect(page).to have_selector 'div.alert.alert-warning'
end

it 'includes survey link' do
visit solr_document_path 'nyu-2451-38684'
expect(page).to have_link(
'this brief survey', href: 'https://nyu.qualtrics.com/jfe/form/SV_42ddIXjT0CtaqAR'
)
end

it 'does not display download' do
visit solr_document_path 'nyu-2451-38684'
expect(page).not_to have_content 'Download'
end

it 'includes DOI for citation' do
visit solr_document_path 'nyu-2451-38684'
expect(page).to have_content 'Please cite this study using the DOI'
expect(page).to have_link(
'doi:10.17609/N8MQ0N', href: 'https://doi.org/10.17609/N8MQ0N'
)
end
end

Expand Down