Skip to content

Fix various warnings #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 4.1
Choose a base branch
from
Open

Fix various warnings #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fce78f
Fix 'clearing an object of non-trivial type' warning
sankhesh Jan 13, 2020
c3210cc
Fix 'binding reference discards qualifiers' warnings
sankhesh Jan 13, 2020
56b2bf6
Fix 'passing argument to restrict-qualified parameter aliase' warnings
sankhesh Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion physx/source/geomutils/src/gjk/GuGJKType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ namespace Gu

virtual Ps::aos::Vec3V getCenter() const { return mAToB.transform(getConvex<Convex>().getCenter()); }

PX_FORCE_INLINE Ps::aos::PsMatTransformV& getRelativeTransform(){ return mAToB; }
PX_FORCE_INLINE Ps::aos::PsMatTransformV& getRelativeTransform(){ return const_cast<Ps::aos::PsMatTransformV&>(mAToB); }

//ML: we can't force inline function, otherwise win modern will throw compiler error
PX_INLINE RelativeConvex<typename ConvexGeom<Convex>::Type > getGjkConvex() const
Expand Down
4 changes: 3 additions & 1 deletion physx/source/geomutils/src/mesh/GuBV4Build.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,8 +294,10 @@ bool AABBTree::buildFromMesh(SourceMesh& mesh, PxU32 limit)
mPool->mNodePrimitives = mIndices;
mPool->mNbPrimitives = nbBoxes;

// Workaround "restrict-qualified parameter aliases" warning
AABBTreeNode* mPoolA = mPool;
// Build the hierarchy
local_BuildHierarchy(mPool, boxes, centers, Stats, mPool, limit);
local_BuildHierarchy(mPoolA, boxes, centers, Stats, mPool, limit);

// Get back total number of nodes
mTotalNbNodes = Stats.getCount();
Expand Down
3 changes: 2 additions & 1 deletion physx/source/physxextensions/src/serialization/Xml/SnXmlSerialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,8 @@ namespace physx { namespace Sn {
, mVersionStr( getLatestVersion() )
, mPxCollection( &inPxCollection )
{
memset( &mScale, 0, sizeof( PxTolerancesScale ) );
mScale.length = 0.0f;
mScale.speed = 0.0f;
PX_ASSERT( mScale.isValid() == false );
}

Expand Down