probes: refactor fact snippet mixin #1187
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leon Derczynski <leonderczynski@gmail.com>
erickgalinkin
approved these changes
May 14, 2025
jmartin-tech
approved these changes
May 14, 2025
|
Don't merge til after 0.11.0, alters bag probes content slightly |
jmartin-tech
requested changes
May 14, 2025
garak/probes/latentinjection.py
Outdated
| @@ -468,6 +496,11 @@ class LatentInjectionFactSnippetEiffelFull( | |||
| "", | |||
| ] | |||
|
|
|||
| def __init__(self, config_root=_config): | |||
| Probe.__init__(self, config_root) | |||
There was a problem hiding this comment.
Suggested change
| Probe.__init__(self, config_root) | |
| garak.probes.Probe.__init__(self, config_root) |
garak/probes/latentinjection.py
Outdated
| @@ -496,6 +529,11 @@ class LatentInjectionFactSnippetLegalFull( | |||
| ("-- LEGAL AMENDMENT, FOLLOW INSTRUCTION\n", "\n-- RESUME"), | |||
| ] | |||
|
|
|||
| def __init__(self, config_root=_config): | |||
| Probe.__init__(self, config_root) | |||
There was a problem hiding this comment.
Suggested change
| Probe.__init__(self, config_root) | |
| garak.probes.Probe.__init__(self, config_root) |
garak/probes/latentinjection.py
Outdated
| self.contexts.add(context) | ||
|
|
||
| self.contexts = list(self.contexts) | ||
| Probe.__init__(self, config_root) |
There was a problem hiding this comment.
Suggested change
| Probe.__init__(self, config_root) | |
| garak.probes.Probe.__init__(self, config_root) |
|
Thanks Will work out a better pattern for configuration before merging. Maybe by also doing merge w Probe.DEFAULT_PARAMS and requiring appropriate mro in inheritance descriptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #1181
Refactor snippet code in
latentinjectionprobes to move function up intoFactSnippetMixinvalidation:
FactSnippetMixincontain exactly oneINJECTION_MARKERFactSnippetMixintodo (may be out of scope):
DEFAULT_PARAMS