-
Notifications
You must be signed in to change notification settings - Fork 217
Make device_reference<T>::operator=
const
#4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bernhardmgruber
merged 4 commits into
NVIDIA:main
from
bernhardmgruber:const_dev_ref_assign
May 20, 2025
Merged
Make device_reference<T>::operator=
const
#4740
bernhardmgruber
merged 4 commits into
NVIDIA:main
from
bernhardmgruber:const_dev_ref_assign
May 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
device_reference<T>::operator=
const
1 task
This is in line with device_reference being a proxy reference, where assigning to a proxy reference does not change the reference itself, but the referred object (the const is shallow). This also makes device_ptr satisfy std::indirectly_writable Fixes: NVIDIA#4621
9faff23
to
7a58630
Compare
miscco
approved these changes
May 19, 2025
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
🟨 CI finished in 2h 19m: Pass: 99%/138 | Total: 3d 01h | Avg: 32m 01s | Max: 1h 39m | Hits: 71%/156470
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
stdpar | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | stdpar |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 138)
# | Runner |
---|---|
95 | linux-amd64-cpu16 |
12 | linux-amd64-gpu-rtxa6000-latest-1 |
11 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
4 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx2080-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
🟩 CI finished in 15h 45m: Pass: 100%/138 | Total: 3d 01h | Avg: 32m 02s | Max: 1h 39m | Hits: 71%/156470
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
stdpar | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | stdpar |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 138)
# | Runner |
---|---|
95 | linux-amd64-cpu16 |
12 | linux-amd64-gpu-rtxa6000-latest-1 |
11 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
4 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx2080-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with
device_reference
being a proxy reference, where assigning to a proxy reference does not change the reference itself, but the referred object (the const is shallow).This also makes
device_ptr
satisfystd::indirectly_writable
.Fixes: #4621