Implement operator<< for cuda::std::string_view
#4736
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| // <cuda/std/string_view> | ||
|
|
||
| // template<class charT, class traits, class Allocator> | ||
| // basic_ostream<charT, traits>& | ||
| // operator<<(basic_ostream<charT, traits>& os, | ||
| // const basic_string_view<charT,traits> str); | ||
|
|
||
| #include <cuda/std/cassert> | ||
| #include <cuda/std/string_view> | ||
| #include <cuda/std/type_traits> | ||
|
|
||
| #include <sstream> | ||
|
|
||
| #include "literal.h" | ||
|
|
||
| template <class CharT> | ||
| void test_with_default_type_traits() | ||
| { | ||
| using OS = std::basic_ostringstream<CharT>; | ||
| using SV = cuda::std::basic_string_view<CharT>; | ||
|
|
||
| // check that cuda::std::char_traits are mapped to std::char_traits | ||
| static_assert(cuda::std::is_same_v<typename OS::char_type, CharT>); | ||
| static_assert(cuda::std::is_same_v<typename OS::traits_type, std::char_traits<CharT>>); | ||
| static_assert(cuda::std::is_same_v<typename SV::value_type, CharT>); | ||
| static_assert(cuda::std::is_same_v<typename SV::traits_type, cuda::std::char_traits<CharT>>); | ||
|
|
||
| const CharT* str = TEST_STRLIT(CharT, "some text"); | ||
|
|
||
| // 1. test basic write without formatting | ||
| { | ||
| OS out{}; | ||
| SV sv{str}; | ||
|
|
||
| out << sv; | ||
| assert(out.good()); | ||
| assert(out.str() == str); | ||
| } | ||
|
|
||
| // 2. test basic write with formatting | ||
| { | ||
| OS out{}; | ||
| SV sv{str}; | ||
|
|
||
| out.width(12); | ||
| out << sv; | ||
| assert(out.good()); | ||
| assert(out.str() == TEST_STRLIT(CharT, " some text")); | ||
| } | ||
| } | ||
|
|
||
| template <class CharT> | ||
| struct custom_type_traits : std::char_traits<CharT> | ||
| {}; | ||
|
|
||
| template <class CharT> | ||
| void test_with_custom_type_traits() | ||
| { | ||
| using OS = std::basic_ostringstream<CharT, custom_type_traits<CharT>>; | ||
| using SV = cuda::std::basic_string_view<CharT, custom_type_traits<CharT>>; | ||
|
|
||
| // check that cuda::std::char_traits are mapped to std::char_traits | ||
| static_assert(cuda::std::is_same_v<typename OS::char_type, CharT>); | ||
| static_assert(cuda::std::is_same_v<typename OS::traits_type, custom_type_traits<CharT>>); | ||
| static_assert(cuda::std::is_same_v<typename SV::value_type, CharT>); | ||
| static_assert(cuda::std::is_same_v<typename SV::traits_type, custom_type_traits<CharT>>); | ||
|
|
||
| const CharT* str = TEST_STRLIT(CharT, "some text"); | ||
|
|
||
| // 1. test basic write without formatting | ||
| { | ||
| OS out{}; | ||
| SV sv{str}; | ||
|
|
||
| out << sv; | ||
| assert(out.good()); | ||
| assert(out.str() == str); | ||
| } | ||
|
|
||
| // 2. test basic write with formatting | ||
| { | ||
| OS out{}; | ||
| SV sv{str}; | ||
|
|
||
| out.width(12); | ||
| out << sv; | ||
| assert(out.good()); | ||
| assert(out.str() == TEST_STRLIT(CharT, " some text")); | ||
| } | ||
| } | ||
|
|
||
| template <class CharT> | ||
| void test_type() | ||
| { | ||
| test_with_default_type_traits<CharT>(); | ||
| test_with_custom_type_traits<CharT>(); | ||
| } | ||
|
|
||
| void test() | ||
| { | ||
| test_type<char>(); | ||
| #if _CCCL_HAS_WCHAR_T() | ||
| test_type<wchar_t>(); | ||
| #endif // _CCCL_HAS_WCHAR_T() | ||
| } | ||
|
|
||
| int main(int, char**) | ||
| { | ||
| NV_IF_TARGET(NV_IS_HOST, (test();)) | ||
| return 0; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
_CCCL_EXEC_CHECK_DISABLEis necessary to allow using e. g. host only char_traitsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit torn here, we should use host only
char_traitsas they will crash.I believe the solution with just casting to
::std::string_viewis the better solutionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the user can pass any type traits he wants, they might be host only, or device only..