-
Notifications
You must be signed in to change notification settings - Fork 217
turn off execution space checks for unique_ptr
#4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🟩 CI finished in 12h 23m: Pass: 100%/183 | Total: 3d 15h | Avg: 28m 50s | Max: 1h 38m | Hits: 68%/283155
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
stdpar | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | stdpar |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 183)
# | Runner |
---|---|
129 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
12 | linux-arm64-cpu16 |
12 | linux-amd64-gpu-rtxa6000-latest-1 |
7 | linux-amd64-gpu-rtx2080-latest-1 |
5 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love some tests added to libcudacxx/test/libcudacxx/std/utilities/memory/smartptr/unique.ptr/unique.ptr.dltr
i honestly don't know how. almost all the test files in maybe @alliepiper can fill me in on how to add CUDA-specific tests to libcudacxx. |
Actually they are not, all libcu++ files are compiled as -x cu and invoked on both host and device. I will create some tests as a followup |
Description
unique_ptr
calls user-provided constructors and destructors from__host__ __device__
functions. suppress execution space errors when the 'structors are host- or device-only.