fix(nnUNet): Correct background mask in BraTS preprocessor #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Maintainer.
This PR fixes the issue described in #1438.
Problem:
The preprocessing code for the BraTS nnU-Net example was using
np.where(image[i] <= 0)to create a background mask. This incorrectly masked out foreground voxels that had negative values after z-score normalization.Solution:
This fix changes the condition to
np.where(image[i] == 0), which correctly identifies only the true background voxels. This ensures the 5th channel mask is generated as intended.Fixes #1438