Skip to content

Conversation

@RohYounwoo
Copy link

Related Issues

None

Changes and Reasons

[-w warmup_iterations] [-o output_dir] --> [-w warmup_iterations] [-j num_threads] [-o output_dir]

For "nvJPEGDecMultipleInstances.cpp", there is an additional num_threads argument compared to "nvjpegDecoder.cpp".
However, the -h,--help option returns no instructions about threads, even though they already have a cool implementation!

Copy link
Collaborator

@hoang-dt hoang-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you please remove the .DS_Store files?

@RohYounwoo
Copy link
Author

Thanks for the PR. Could you please remove the .DS_Store files?

Thank you for the review! I just removed the .DS_Store files. Could you please confirm it?

@kvoronin
Copy link
Collaborator

Hi @RohYounwoo!

We have changed the license of the repository from BSD-3 to Apache 2.0 to allow accepting external contributions in the right way.

What this means is that

  • the new default branch is main. (The old one called master is still there, but master and an extra bsd3_main are not supposed to be changed)
  • all commits to the repository must be signed, see the new https://github.com/NVIDIA/CUDALibrarySamples/blob/main/CONTRIBUTING.md. Technically, it is as simple as doing git commit -s ... which would enforce DCO for the contribution (see more details in the CONTRIBUTING.md).

What this means for this PR:
Please change the target branch to main (potentially instead of rebase it is easier to cherry-pick commits into a new branch) and sign the commits.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants