feat: fp32 lm_head and fp32 apply_rope options for MoE #769
+377
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemildesai
requested review from
HuiyingLi,
adil-a and
akoumpa
as code owners
akoumpa
reviewed
Nov 5, 2025
| if lm_head is not None: | ||
| fully_shard_default(lm_head) | ||
| # Use custom mixed precision policy for lm_head if lm_head_precision is specified | ||
| if lm_head_precision == torch.float32: |
There was a problem hiding this comment.
is it possible to inspect the lm_head to figure out the precision?
There was a problem hiding this comment.
This option is to force lm head in fp32 regardless of checkpoint dtype. fp32 lm_head helps with RL stability.
Signed-off-by: Hemil Desai <hemild@nvidia.com>
hemildesai
force-pushed
the
hemil/fp32-lmhead-rope
branch
from
3579886 to
945039c
Compare
|
/ok to test 2e79028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.