-
Notifications
You must be signed in to change notification settings - Fork 0
fix: [KAN-40] add client path param #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a :client path parameter to user management API endpoints to differentiate between customer and merchant client requests, implementing the requirement from KAN-40.
- Introduces client validation middleware to ensure only "customer" or "merchant" values are accepted
- Updates all authentication and user management endpoints to include the client path parameter
- Updates Swagger documentation to reflect the new API structure
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/http/router/router.go | Adds client path parameter to route groups and implements validation middleware |
| server/http/api/register.go | Updates registration and activation endpoint documentation with client parameter |
| server/http/api/login.go | Updates login and logout endpoint documentation with client parameter |
| server/docs/swagger.yaml | Updates OpenAPI specification with client path parameters |
| server/docs/swagger.json | Updates generated JSON documentation with client path parameters |
| server/docs/docs.go | Updates generated Go documentation with client path parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4065938 to
ee189fe
Compare
ee189fe to
527a5b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
527a5b8 to
2d66b9c
Compare
2d66b9c to
1d5424b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1d5424b to
ed62ec7
Compare
name: Pull Request | 合并请求
about: 修复或改进 | Submit a fix, or improvement
labels: ["fix"]
变更内容 | Changes
add a :client path parameter to each api, to differentiate requests from customer/merchant
相关 Issue | Related Issue
[KAN-40 Use Service API distinguish between merchant-frontend and customer-frontend] (https://cerami-craft.atlassian.net/browse/KAN-40)
变更类型 | Type of Change
检查清单 | Checklist
变更影响 | Impact
frontend need to adjust new api
测试说明 | Test Instructions
test login/logout (merchant/customer)
test registration/activatation (customer)
其他说明 | Additional Notes