Skip to content

Conversation

@lianjin
Copy link
Contributor

@lianjin lianjin commented Sep 26, 2025


name: Pull Request | 合并请求
about: user registration and activation
labels: ["feature"]

变更内容 | Changes

  1. add register api
  2. add activation api

相关 Issue | Related Issue

KAN-18 User Registration

变更类型 | Type of Change

  • 新功能 Feature
  • 修复 Bug Fix
  • 文档 Documentation
  • 样式优化 Style
  • 重构 Refactor
  • 性能优化 Performance
  • 测试 Test
  • 构建/CI Build/CI
  • 其他 Other

检查清单 | Checklist

  • 代码已通过本地测试(含主流浏览器/终端)| Code tested locally (including major browsers/terminals)
  • 相关文档已更新(如有)| Documentation updated if needed
  • 代码风格符合项目规范 | Code style follows project conventions
  • 变更不会影响现有功能 | Changes do not break existing features
  • 已自查无敏感信息泄露 | No sensitive info is leaked

变更影响 | Impact

none

测试说明 | Test Instructions

  1. register with real email
  2. password should have alpha and digit both and len >= 8
  3. newly inactivated user will receive 6-lengh opt code, if user already activated, will receive error msg
  4. call activate API with opt code, complete the activation step

其他说明 | Additional Notes

@lianjin lianjin requested review from Copilot and yzcgg September 26, 2025 14:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements user registration and activation functionality for the CeramiCraft user microservice, allowing new users to register with email/password and activate their accounts via email verification codes.

  • Add user registration API with password validation and email verification
  • Add user activation API with 6-digit verification codes
  • Implement email service integration for sending activation codes

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
server/service/register.go Core registration service with user creation and activation logic
server/service/register_test.go Comprehensive unit tests for registration and activation flows
server/http/api/register.go HTTP API endpoints for registration and activation
server/http/router/router.go Router configuration with custom password validation
server/proxy/email.go Email service implementation for sending activation codes
server/repository/dao/user_activation_dao.go Data access layer for user activation records
server/http/data/user.go Request/response data structures with validation
server/config/config.go Configuration updates for email service

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch from b63d4df to 8478844 Compare September 27, 2025 01:42
Copilot AI review requested due to automatic review settings September 27, 2025 01:52
@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch from 8478844 to 666ed51 Compare September 27, 2025 01:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch 2 times, most recently from 7ce4aa7 to 3dd3346 Compare September 27, 2025 02:11
Copilot AI review requested due to automatic review settings September 27, 2025 02:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch from 3dd3346 to d5213e5 Compare September 27, 2025 02:21
Copilot AI review requested due to automatic review settings September 27, 2025 02:30
@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch from d5213e5 to a5f6a11 Compare September 27, 2025 02:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch 2 times, most recently from 923b5b2 to 5dcf837 Compare September 27, 2025 02:46
Copilot AI review requested due to automatic review settings September 27, 2025 02:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-18-feat-User-Registration branch from 5dcf837 to 2adacb6 Compare September 27, 2025 02:52
@yzcgg yzcgg merged commit 44528e0 into main Sep 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants