Skip to content

Conversation

@lianjin
Copy link
Contributor

@lianjin lianjin commented Sep 25, 2025


name: fix deployment bug
about: depoymeng fail with missing env var & log write permission
labels: ["fix"]

变更内容 | Changes

  1. Dockerfile: chmod +w logs
  2. deployment.yml: add docker run env

相关 Issue | Related Issue

KAN-34 User Service Deployment Fail

变更类型 | Type of Change

  • 新功能 Feature
  • 修复 Bug Fix
  • 文档 Documentation
  • 样式优化 Style
  • 重构 Refactor
  • 性能优化 Performance
  • 测试 Test
  • 构建/CI Build/CI
  • 其他 Other

检查清单 | Checklist

  • 代码已通过本地测试(含主流浏览器/终端)| Code tested locally (including major browsers/terminals)
  • 相关文档已更新(如有)| Documentation updated if needed
  • 代码风格符合项目规范 | Code style follows project conventions
  • 变更不会影响现有功能 | Changes do not break existing features
  • 已自查无敏感信息泄露 | No sensitive info is leaked

变更影响 | Impact

none

测试说明 | Test Instructions

none

其他说明 | Additional Notes

@lianjin lianjin requested review from Copilot and yzcgg September 25, 2025 08:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes deployment issues in the user service by addressing missing environment variable and log directory permissions problems.

  • Corrects log directory naming from log to logs for consistency
  • Adds missing MYSQL_PASSWORD environment variable to Docker deployment
  • Updates log file path to match the corrected directory structure

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
server/resources/config.yml Updates log file path to use correct directory name
server/Dockerfile Changes log directory from log to logs and sets proper permissions
.github/workflows/deploy.yml Adds missing MYSQL_PASSWORD environment variable to Docker run command

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lianjin lianjin force-pushed the KAN-34-User-Service-Deployment-Fail branch from c4d5909 to 32e7ec3 Compare September 25, 2025 08:12
@yzcgg yzcgg merged commit a340df8 into main Sep 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants