Skip to content

Conversation

@nileshsawant
Copy link
Collaborator

@nileshsawant nileshsawant commented Sep 11, 2025

Possible fix to AMR reflections. compute_q_corrections is needed before macrodata_to_equilibrium and is possible only after f_to_macrodata. Sequence was correct only in collision

@marchdf marchdf changed the title Possible fix to AMR reflections. compute_q_corrections is needed before macrodata_to_equilibrium and is possible only after f_to_macrodata. Sequence was correct only in collision Potential fix to reflections at AMR levels Sep 11, 2025
@marchdf marchdf marked this pull request as draft September 11, 2025 18:03
@marchdf
Copy link
Collaborator

marchdf commented Sep 23, 2025

Can you put amr_cylinder_turek_2d2.inp into its own test folder? Ideally it would be: cylinder_turek_2d2_amr/cylinder_turek_2d2_amr,inp for consistency. And then add it and the other turek as a test that is run: https://github.com/NREL/marbles/blob/main/Tests/CMakeLists.txt#L92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants