-
Notifications
You must be signed in to change notification settings - Fork 35
[1pt] FIM Performance for Alaska and logging #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobHanna-NOAA
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already ran a full scale and data validated.
RobHanna-NOAA
previously approved these changes
Aug 30, 2024
RobHanna-NOAA
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade for
test_case_by_hydro_id.pythat enables the ability to run on HUCs with differing projections (e.g. Alaska) and adds a logging system.Changes
tools/test_case_by_hydro_id.py: Moved the reprojection step to accommodate multiple input projections and fixed a lot of unnecessary logic. Also added an optional logging system that is activated by the new-lflag.Testing
The following was used to create the FIM Performance layer for the v4.5.2.11 release. It required approximately 32 hours to run.
python /foss_fim/tools/test_case_by_hydro_id.py -b all -v fim_4_5_2_11 -g /outputs/fim_performance_v4_5_2_11.gpkg -lDeployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>devbranch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>(e.g.dev-revise-levee-masking)devbranchpre-commithooks were run locally4.x.x.xMerge Checklist (For Technical Lead use only)