Skip to content

Conversation

@mluck
Copy link
Contributor

@mluck mluck commented Aug 8, 2024

Indents the mosaicking block so that inundate_mosaic_wrapper.py mosaics both inundation extents and depths. Fixes #1245.

Changes

  • tools/inundate_mosaic_wrapper.py: Moves mosaicking inside for loop.

Testing

Ran tools/inundate_mosaic_wrapper.py and verified that both depth and extent rasters are mosaicked.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck added the bug Something isn't working label Aug 8, 2024
@mluck mluck requested a review from RobHanna-NOAA August 8, 2024 14:49
@mluck mluck changed the title [1pt] Mosaic depths and extents [1pt] PR: Mosaic depths and extents Aug 8, 2024
hhs732
hhs732 previously approved these changes Sep 3, 2024
Copy link
Contributor

@hhs732 hhs732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two different tests were successfully run for this PR:

  1. synthesize_test_cases.py was executed for two hucs of 12090301 and 03170005. To test if this PR creates depth rasters 'run_test_cases.py` was modified (line 342) to produce depth rasters.
  2. inundate_mosaic_wrapper.py was executed for the same hucs as above with 2 different flow files.

“RobHanna-NOAA” added 2 commits September 13, 2024 17:02
RobHanna-NOAA
RobHanna-NOAA previously approved these changes Sep 13, 2024
@CarsonPruitt-NOAA CarsonPruitt-NOAA merged commit 20640c9 into dev Sep 13, 2024
1 check passed
@CarsonPruitt-NOAA CarsonPruitt-NOAA deleted the dev-fix-inundate_mosaic_wrapper branch September 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1pt] Error in mosaicking depth rasters

4 participants