Skip to content

Conversation

@taddyb
Copy link

@taddyb taddyb commented Sep 30, 2025

Note

This is the last PR for NGWPC EDFS deliveries for the icefabric repo and contains a delivery for NGWPC-5541. This work was completed in September of 2025, and new commits to the NGWPC fork have been made since the work went through NGWPC test. Please merge this PR last if merging in all PRs. The full repo commit history is available at: https://github.com/NGWPC/icefabric/commits/main/

To use the remote PyIceberg endpoint, you will need RTX NGWPC AWS creds to our test account. Please contact Tadd Bindas with any questions for access.

Additions

  • NGWPC-5541
    • Provide access to the RAS Cross Sections: Implement a REST service API to access the Spatiotemporal Asset Catalog (STAC) that references the RAS cross-sections currently stored on S3 which has been built to support the RAS library generation. The STAC can be used to view all of the available cross-section data and make queries to get the data desired. The cross-section data will be accessible to users by the NWM river segments (feature_id).
    • Code for this example is in: examples/iceberg_data_viewer/ras_xs_api.ipynb

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

taddyb and others added 30 commits April 25, 2025 18:56
warning is expected: Iceberg does not have a dictionary type. <class 'pyarrow.lib.DictionaryType'> will be inferred as int32 on read.
initial commit of new api prototype
brock-hinkson and others added 27 commits August 12, 2025 19:10
* initial commit: added rustworkx graph support

* initial commit: added rustworkx graph support

* feat: added support for updating hydrofabric snapshots, added API support

* test: added tests for subsets. Will fix catalog mocks later

* test: fixed hf subset tests

* fix: ensured subsetting will always return a catchment if there is a valid origin

* fix:ensured router code removed upstream connections

* fix: added ambiance check
* initial commit: patched viewer, and added new viewer for ras xs

* patch: added glue catalog support for ras_xs
* fix: patched IPE module code to accomidate for new subset code

* patch: removed reference to module
* initial commit: moved external rise functions to icefabric source dir

* fix: ensured router code removed upstream connections

* fix: added print statement for end of tool

* initial commit: patched viewer, and added new viewer for ras xs (#92)

* initial commit: patched viewer, and added new viewer for ras xs

* patch: added glue catalog support for ras_xs

* PATCH: patched IPE module code to accomidate for new subset code (#94)

* fix: patched IPE module code to accomidate for new subset code

* patch: removed reference to module

* fix: cleaned up data contained in outputted usbr_data_retrieval.py
adding gage list and GL divide attr R code
* NGWPC-6508 - Create CLI endpoint for hourly streamflow

* NGWPC-6508 - Fix CSV generation, add functionality and options

* Update tools/icechunk/get_envca_cadwr_txdot_gages_from_s3.py

---------

Co-authored-by: Tadd Bindas <Tadd.N.Bindas@rtx.com>
…DFS updates (#106)

* initial commit: updated rnr to latest icefabric changes

* fix: removed debugging endpoints

* fix: fixed local error with snapshot table being defined incorrectly
* patch: changed parsing to be outside of the main function for universal access

* initial commit of LSTM notebook

* commit lstm notebook without outputs

* fix comments from PR

* patch: changing sample graph to pull from tests/data

* patch: remove the gl_hf

* NGWPC-7219: Initial IaC and Dependencies

Initial take a github action workflow with failing stages commented out
to get an image built with mkdocs at the root for IaC work.

Terraform IaC required for deploy to Test.

---------

Co-authored-by: taddyb <tkb5476@psu.edu>
Co-authored-by: Daniel Cumpton <dccumpton@rtx.com>
* NGWPC-7483 - Create API Endpoints to Query RAS-XS

* NGWPC-7483 - Fix RAS-XS Iceberg tables and fix deprecations

* NGWPC-7483 - Fix potential path traversal exploit

* NGWPC-7483 - Fix CodeQL issues

* NGWPC-7483 - Fix CodeQL issues again
@taddyb taddyb marked this pull request as ready for review October 1, 2025 19:17
@DJackson2313
Copy link

SWCM witnessed; concurrence granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

7 participants