Skip to content

Conversation

@jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Jul 28, 2025

Updates (yet again) the event_loop syntax in the _restclient tests.

https://pytest-asyncio.readthedocs.io/en/stable/how-to-guides/migrate_from_0_21.html

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c self-assigned this Jul 28, 2025
@jarq6c jarq6c added the bug Something isn't working label Jul 28, 2025
@jarq6c
Copy link
Collaborator Author

jarq6c commented Jul 28, 2025

FYI: @aaraney I'll merge this later this week.

@aaraney
Copy link
Member

aaraney commented Jul 28, 2025

Thanks for being on top of and handling this grunt work, @jarq6c!

@jarq6c jarq6c merged commit 20fd9d4 into NOAA-OWP:main Jul 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants