Skip to content

Conversation

@jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Mar 6, 2025

Adds a module to compute basic estimates of canopy interception using reasonable defaults from literature.

Additions

  • compute_canopy_saturation
  • compute_trunk_saturation
  • compute_canopy_loss
  • compute_trunk_loss
  • compute_interception

Removals

Changes

Testing

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the enhancement New feature or request label Mar 6, 2025
@jarq6c jarq6c requested a review from hellkite500 March 6, 2025 19:55
@jarq6c jarq6c self-assigned this Mar 6, 2025
@jarq6c
Copy link
Collaborator Author

jarq6c commented Mar 14, 2025

Thanks @hellkite500 ! I implemented your recommendations. The module passes all tests and will be merged.

@jarq6c jarq6c merged commit d94a28e into NOAA-OWP:main Mar 14, 2025
3 checks passed
@jarq6c jarq6c deleted the interception branch March 17, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants