Skip to content

Conversation

@jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Mar 5, 2025

Adds a flow_duration_curve module to hydrotools.metrics. Includes methods for empirical FDCs, modeled FDCs (log pearson type iii), bootstrapping CIs, interpolation, conversion between exceedance probabilities and recurrence intervals, and flow variability indices.

Additions

  • empirical_flow_duration_curve
  • pearson_flow_duration_curve
  • bootstrap_flow_duration_curve
  • exceedance_values
  • recurrence_values
  • richards_flow_responsiveness

Removals

Changes

Testing

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the enhancement New feature or request label Mar 5, 2025
@jarq6c jarq6c self-assigned this Mar 5, 2025
Copy link

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work! Everything is organized and well documented. My comments are merely nit picking but addressable at your discretion.

@jarq6c
Copy link
Collaborator Author

jarq6c commented Mar 6, 2025

Thanks @GregoryPetrochenkov-NOAA I've implemented your recommendations.

@jarq6c jarq6c merged commit dad9293 into NOAA-OWP:main Mar 6, 2025
3 checks passed
@jarq6c jarq6c deleted the fdc branch March 7, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants