Аникин Максим. Лабораторная работа 1. Clang Ast. Вариант 1. #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decl1
requested review from
aobolensk,
m-ly4 and
Kuznetsov-Artyom
as code owners
aobolensk
requested changes
Mar 19, 2025
| @@ -0,0 +1,42 @@ | |||
| // RUN: %clang_cc1 -load %llvmshlibdir/DataType_Anikin_Maksim_FIIT2_ClangAST%pluginext -plugin data_type -fsyntax-only %s 2>&1 | FileCheck %s | |||
|
|
|||
There was a problem hiding this comment.
Consider adding tests for union covered in your pass
aobolensk
approved these changes
Mar 21, 2025
Kuznetsov-Artyom
requested changes
Mar 22, 2025
Comment on lines
+6
to
+7
| #include <algorithm> | ||
| #include <string> |
There was a problem hiding this comment.
You need these header files?
| #include <algorithm> | ||
| #include <string> | ||
|
|
||
| namespace anikin_m_ast { |
There was a problem hiding this comment.
In the context of a plugin, then it is better to use an anonymous namespace
Comment on lines
+69
to
+71
| [](const clang::ParmVarDecl *param) { | ||
| llvm::outs() << param->getType().getAsString(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| [](const clang::ParmVarDecl *param) { | |
| llvm::outs() << param->getType().getAsString(); | |
| } | |
| [&out](const clang::ParmVarDecl *param) { | |
| out << param->getType().getAsString(); | |
| } |
| } | ||
| } | ||
|
|
||
| class ASTWalker final : public clang::RecursiveASTVisitor<ASTWalker> { |
There was a problem hiding this comment.
It is better to follow the generally accepted naming when writing your classes (Visitor, Consumer, Action)
| } // namespace anikin_m_ast | ||
|
|
||
| static clang::FrontendPluginRegistry::Add<anikin_m_ast::ASTPluginAction> | ||
| Y("data_type", "Analyzes AST and prints information about data types"); |
There was a problem hiding this comment.
Suggested change
| Y("data_type", "Analyzes AST and prints information about data types"); | |
| Y("data_type", "Analyzes AST and prints information about data types"); | |
There was a problem hiding this comment.
Add test please
struct A {};
struct B {
struct A {};
};
m-ly4
reviewed
Mar 25, 2025
| namespace anikin_m_ast { | ||
|
|
||
| std::string getAccessSpecifierString(clang::AccessSpecifier access) { | ||
| if (access == clang::AS_public) |
There was a problem hiding this comment.
switch..case is a bit more effective here.
Comment on lines
+43
to
+46
|
|
||
| out << "|" << getAccessSpecifierString(var->getAccess()); | ||
|
|
||
| out << ")\n"; |
There was a problem hiding this comment.
Suggested change
| out << "|" << getAccessSpecifierString(var->getAccess()); | |
| out << ")\n"; | |
| out << "|" << getAccessSpecifierString(var->getAccess()) << ")\n"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Данный плагин для clang производит анализ пользовательских типов данных.
Плагин проверяет тип данных на поля, методы и наследование.
Выводит о них информацию: тип данных, доступ, характеристики.