Кошкин Никита. Лабораторная работа 3: BACKEND. Вариант 2. #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaKoshkin
requested review from
aobolensk,
m-ly4 and
Kuznetsov-Artyom
as code owners
aobolensk
requested changes
Jun 10, 2025
Comment on lines
+244
to
+249
| for (const auto &opcode : simd_opcodes) { | ||
| if (OpcodeName == opcode) { | ||
| isSimd = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider using hash set or tree set data structure for better lookup (for instance, DenseSet) and you can replace this loop with a condition that would check if instruction is in SIMD scope or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пасс для LLVM, который после каждой найденной SIMD-инструкции в MIR добавляет инкремент глобального счётчика. Используется для подсчёта числа выполненных векторных инструкций.
Для обнаружения SIMD-инструкций пасс сравнивает имена опкодов с набором наиболее часто используемых SIMD-инструкций (понимаю, что не оптимально, поэтому ожидаю ревью на эту тему...).