Дормидонтов Егор. Лабораторная работа 4. MLIR. Вариант 4. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorDormidontov
requested review from
aobolensk,
m-ly4 and
Kuznetsov-Artyom
as code owners
aobolensk
requested changes
Jun 10, 2025
Comment on lines
+53
to
+54
| llvm::outs() << "Func " << funcOp.getName() | ||
| << ": max_loop_region_depth = " << maxDepth << "\n"; |
There was a problem hiding this comment.
Suggested change
| llvm::outs() << "Func " << funcOp.getName() | |
| << ": max_loop_region_depth = " << maxDepth << "\n"; |
| } | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Please, add the test where scf.for is not top level in the function, e.g.:
func() {
scf.if ... {
scf.for {
}
}
}
| @@ -0,0 +1,54 @@ | |||
| // RUN: mlir-opt -load-pass-plugin=%mlir_lib_dir/MaxLoopRegionDepthPass_Dormidontov_Egor_FIIT2_MLIR%shlibext \ | |||
| // RUN: --pass-pipeline="builtin.module(MaxLoopRegionDepthPass_Dormidontov_Egor_FIIT2_MLIR)" %s | FileCheck %s | |||
|
|
|||
There was a problem hiding this comment.
You have an implementation for affine loops, but do not have tests for them
|
|
||
| // ###Цикл с if внутри и if во вложении, глубина = 3 | ||
| // CHECK-LABEL: func.func @deep_nest | ||
| // CHECK: attributes {max_loop_region_depth = 3 : i32} |
There was a problem hiding this comment.
Your tests do not check that attributes attached to the right loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Данный пасс вычисляет максимальную глубину вложенности региональных операторов внутри каждой функции в модуле.
Для каждой функции пасс рекурсивно проходит по всем регионам и находит максимальный уровень вложенности.