NCRS-3931 Close mobile menu on lost focus & fix aria toggling #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMitchellBJSS
added
bug
alice-bell
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Reviewed this for NCRS-3931. I've played with the branch locally and also tested how it works when imported into NCRS for our menu dropdown. Everything behaves as expected. Clicking off the menu makes it disappear, the chevron flips correctly, and the aria-expanded toggles between true and false at the right times. Thanks Cal :)
EDIT: just noticed that one of the snap tests is failing, but will re-approve as soon as this is sorted. Everything else looks good.
|
alice-bell
approved these changes
Jun 17, 2025
CalMitchellBJSS
deleted the
feature/NCRS-3931-close-mobile-menu-on-lost-focus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality so the HeaderWithLogo dropdown menu closes on lost focus. Also removed duplicated functionality where the toggle's aria label was set via the context, not the header.js. I've also added a toggled class so chevron styling isn't reliant on pseudo classes.