Skip to content

Conversation

@jswade-rtx
Copy link
Contributor

@jswade-rtx jswade-rtx commented Sep 2, 2025

Bug fix for error raised when trying to run calibrations for GWO or PSO caused by deprecated Pydantic syntax (https://jira.nextgenwaterprediction.com/browse/NGWPC-7570).

Additions

Removals

Changes

  • Pydantic V2 bug fixes to agent.py and calibration.py to enable GWO and PSO calibration runs

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux
  • MacOS

Copy link
Contributor

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested running this update in AWS workspace for both PWO and GWO.

@cmaynard-ngwpc cmaynard-ngwpc merged commit 69ffaee into development Sep 2, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants