Skip to content

Conversation

@PhilMiller
Copy link

@PhilMiller PhilMiller commented Sep 12, 2025

CFE presently gives units of its input variables ice_fraction_xinanjiang and soil_moisture_profile as the string "none". Both of these are dimensionless fraction quantities. However, the UDUNITS2 library we use to parse units doesn't parse "none" as indicating a dimensionless quantity.

Changes

  • Change "none" to "1" so that UDUNITS2 understands it as a dimensionless quantity.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

…ure_profile as "1" so UDUNITS2 can parse them
Copy link

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@PhilMiller PhilMiller merged commit b941a5b into development Sep 12, 2025
1 check failed
@PhilMiller PhilMiller deleted the PhilMiller-7604-dimensionless-inputs branch September 12, 2025 21:32
@PhilMiller PhilMiller restored the PhilMiller-7604-dimensionless-inputs branch September 13, 2025 00:00
@cmaynard-ngwpc cmaynard-ngwpc deleted the PhilMiller-7604-dimensionless-inputs branch September 16, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants