Skip to content

Conversation

@yuqiong77
Copy link

@yuqiong77 yuqiong77 commented Sep 9, 2025

[Short description explaining the high-level reason for the pull request]

Added a check in function conceptual_reservoir_flux_calc to guarantee that the flux never exceeds the available storage

See comments at: https://jira.nextgenwaterprediction.com/browse/NGWPC-7616

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cmaynard-ngwpc cmaynard-ngwpc merged commit 1aa4241 into development Sep 9, 2025
1 check failed
@cmaynard-ngwpc cmaynard-ngwpc deleted the cfe_flux_error branch September 16, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants