Skip to content

Throttle groundwater flux warning message to a single log entry. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

Throttle groundwater flux warning message to a single log entry. #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/cfe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
#include "cfe.h"
#include "logger.h"
#include <stdbool.h>

#define max(a,b) ({ __typeof__ (a) _a = (a); __typeof__ (b) _b = (b); _a > _b ? _a : _b; })
#define min(a,b) ({ __typeof__ (a) _a = (a); __typeof__ (b) _b = (b); _a < _b ? _a : _b; })

static bool groundwaterFluxIssueLogged = false;

// CFE STATE SPACE FUNCTION // #######################################################################
// Adapted version of Conceptual Functional Equivalent model re-written in state-space form July, 2021
//####################################################################################################
Expand Down Expand Up @@ -242,14 +245,17 @@ extern void cfe(

flux_from_deep_gw_to_chan_m=primary_flux; // m/h <<<<<<<<<< BASE FLOW FLUX >>>>>>>>>
if(flux_from_deep_gw_to_chan_m > gw_reservoir_struct->storage_m) {
flux_from_deep_gw_to_chan_m=gw_reservoir_struct->storage_m;
// TODO: set a flag when flux larger than storage
// Adding specific warning message requested by OWP (9/11/2025)
Log(WARNING,
"Groundwater flux larger than storage. "
"While this will not cause a run failure, "
"parameter combinations may not be realistic "
"and a mass balance error will occur.\n");
flux_from_deep_gw_to_chan_m=gw_reservoir_struct->storage_m;
// TODO: set a flag when flux larger than storage
// Adding specific warning message requested by OWP (9/11/2025)
if (!groundwaterFluxIssueLogged) {
Log(WARNING,
"Groundwater flux larger than storage. "
"While this will not cause a run failure, "
"parameter combinations may not be realistic "
"and a mass balance error will occur.\n");
groundwaterFluxIssueLogged = true;
}
}

massbal_struct->vol_from_gw+=flux_from_deep_gw_to_chan_m;
Expand Down
Loading