Skip to content

Unit Conversion Error (NGWPC-7604) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2025
Merged

Unit Conversion Error (NGWPC-7604) #10

Changes from 4 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8769f48
Merge pull request #9 from NGWPC/PhilMiller-7604-dimensionless-inputs
cmaynard-ngwpc Sep 15, 2025
2328607
ice_fraction_schaake (dimensionless)
mkarim-rtx Sep 17, 2025
932c3a9
SURF_RUNOFF_SCHEME unit from None to 1 (dimensionless)
mkarim-rtx Sep 17, 2025
fbb43de
Merge branch 'development' into unit_conversion_mohammed
cmaynard-ngwpc Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/bmi_cfe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ static const char *output_var_units[OUTPUT_VAR_NAME_COUNT] = {
"m",
"m",
"m",
"none",
"1",
"m"
};

Expand Down Expand Up @@ -319,9 +319,9 @@ static const char *input_var_types[INPUT_VAR_NAME_COUNT] = {
static const char *input_var_units[INPUT_VAR_NAME_COUNT] = {
"mm h-1", //"atmosphere_water__liquid_equivalent_precipitation_rate"
"m s-1", //"water_potential_evaporation_flux"
"m", // ice fraction in meters
"none", // ice fraction [-]
"none" // soil moisture profile is in decimal fraction -rlm
"1", // ice fraction should be dimensionless
"1", // ice fraction [-]
"1" // soil moisture profile is in decimal fraction -rlm
};

static const int input_var_item_count[INPUT_VAR_NAME_COUNT] = {
Expand Down
Loading