Skip to content

Conversation

@jsauer-NCAR
Copy link
Collaborator

@jsauer-NCAR jsauer-NCAR commented Sep 12, 2025

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]

    If yes, please describe:

    No

Pull Request Testing

  • Describe testing already performed for these changes:

    Tested on several cases which previous coupler showed unexpected shift in nested FE domain and/or inappropriate extrapolation at upper-bound in the x and/or y directions.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    N/A
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    N/A
  • Do these changes include sufficient testing updates? [Yes or No]
    N/A
  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No
  • Please complete this pull request review by [Fill in date].

    9/12/25

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

jprestop and others added 30 commits May 13, 2025 13:09
…akefile build based on definition of shell variable and conditional compilation including definition of preprocessor directives which alllow inclusion of source and header files for GAD (and EXTENSIONS) functionality.
…files for host (CPU) and device (GPU) layers
…nce velocity magnitude and direction for each turbine.
…ent perpendicular to the nacelle wind direction
…s improved isolation of urban functionality and style consistency modifications.
…nto two global kernel definitions and restructure to achieve all functionality within the reduced kernel set. Also removed objects files inadvertently added in the last commit.
…lpertDevice.cu that needed to be wrapped in the URBAN_EXT preprocessing directive in order to compile cleanly with or without the URBAN_EXT being activated.
rev2_Urban (fix for basic non-URBAN_EXT builds)
…its and forcing_long_name are no longer hardcoded in the lookup table
jprestop and others added 28 commits August 21, 2025 13:30
…ed and have the same long names and units for consistency. Code now accounts for var prefixes like TauTH, Tau, etc.
Fixed seg-fault when running a WITH_GAD=1 but under GADSelector=0
…o FE-domain setup pertaining to ensuring strict interpolation is carried out as opposed to permitting extrapolation in the horizontal directions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants