-
Notifications
You must be signed in to change notification settings - Fork 36
Coupler hardening and correctness revisions #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akefile build based on definition of shell variable and conditional compilation including definition of preprocessor directives which alllow inclusion of source and header files for GAD (and EXTENSIONS) functionality.
…files for host (CPU) and device (GPU) layers
…nce velocity magnitude and direction for each turbine.
…ent perpendicular to the nacelle wind direction
Feature gad
…lving merging conflicts with develop
Feature urban
…s improved isolation of urban functionality and style consistency modifications.
…nto two global kernel definitions and restructure to achieve all functionality within the reduced kernel set. Also removed objects files inadvertently added in the last commit.
Review of URBAN module
…lpertDevice.cu that needed to be wrapped in the URBAN_EXT preprocessing directive in order to compile cleanly with or without the URBAN_EXT being activated.
rev2_Urban (fix for basic non-URBAN_EXT builds)
…feature_88_nc_data_attr
…its and forcing_long_name are no longer hardcoded in the lookup table
…ed and have the same long names and units for consistency. Code now accounts for var prefixes like TauTH, Tau, etc.
… added fill values from the python code
… comment in output
Fixed seg-fault when running a WITH_GAD=1 but under GADSelector=0
…o ioDefineNetCDFcoordVarAttrs
Feature 88 nc data attr
…o FE-domain setup pertaining to ensuring strict interpolation is carried out as opposed to permitting extrapolation in the horizontal directions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
No
Pull Request Testing
Tested on several cases which previous coupler showed unexpected shift in nested FE domain and/or inappropriate extrapolation at upper-bound in the x and/or y directions.
N/A
N/A
N/A
If yes, describe the new output and/or changes to the existing output:
No
9/12/25
Pull Request Checklist