Additions for v3.0 release #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First set of CP method code additions (does not include TVC).
python coupling tools (1/3): GeoSpec
…LCD land cover to z0m clook up table and geospec.json file
Wrf coupling python
…tric tensor terms to accomodate terrain following coordinate frame.
… the formulation of cell face velocties (for advection terms) and calculation of pressure gradient force components.
…in the moleuler diffusion term submodule.
…aing-following coordinate in sgsTKE prognostic equation and sgs Turbulence closure terms.
…ed Jacobian calculation routine
Bugfix to get the terrain following coordinate actually in place
…Cs from Bndy files.
… adding self-consistent formulations of th0 (omitting any use of pres_grnd) in surface layer schemes.
feature/fe coupling Initial phase
…ut files, also ensured strict update of master simTime to be a perfect multiple of dt (avoiding roundoff error in simTime) and implemented the ability to read/write int variables in the netcdf and binary modes of the IO module to allow for upcoming TVCP parameters.
…files feature/time_variable_in_output_files
…bmodule and added a few small code cleanup modifications.
feature/TVCP
…h new formulation for u,v, and w that lack a base state description and to intrdoduce the ceilingAdvectionBC parameter to accomodate coupling and turn off rigid-lid that sets w=0 at the ceiling.
…ments feature/final_coupling_BCs_adjustments
…o default as off.
…MPI_Barrier following final output file write to ensure rank-synchronized cleanup and exit on simulation end, and provide missing broadcast of scalar float variables when reading a NetCDF restart file.
…g/gathering various fields during NetCDF IOis reset to zero everywhere before use in the scatter gather of each registered variable field. This prevents inadvertent pollution of halo cells observed in some fields (e.g. hydroauzscalars at the western boudnary on restart).
…tained them in the CUDA submodules of HYDRO_CORE.
…previous commit ()
Wrf coupling python -> final adjustments to the pre-processing utilities
…nd., and true use of iol in exchange coeffs)
This was
linked to
issues
Apr 11, 2025
jsauer-NCAR
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Numerous tests including previous Examples from tutorials(1,2,3,7) and a new tutorial example (8) to be introduced in another PR.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Documentation will be introduced in a subsequent PR.
Do these changes include sufficient testing updates? [Yes or No]
N/A
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
N/A
Please complete this pull request review by [Fill in date].
4-11-2025
Pull Request Checklist