Text layer #15
Open
Text layer #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the GeographicText interface by adding getter / setter methods to specify an offset. - Implemented the abovementioned getter / setter methods in the UserFacingText class. - Modified both the GeographicTextRenderer and DeclutteringTextRenderer classes by making use of the abovementioned offset property to offset the text of a GeographicText object relative to its position.
Modified the DeclutteringTextRenderer class by adding an additional field called effect. Also, changed this class' drawText() method to be similar to the GeographicTextRenderer class' method where the abovementioned effect field is read to determine if a shadow or an outline should be drawn.
Renamed GeographicTextRenderer to BasicGeographicTextRenderer as we are going to introduce a new inteface called GeographicTextRenderer.
- Added a new interface called GeographicTextRenderer. This interface contains methods that are shared between the DeclutteringTextRenderer and BasicGeographicTextRenderer such as getEffect(), setEffect() and the important render() method. - Modified the BasicGeographicTextRenderer class by changing its render() method's signature to correspond to the GeographicTextRenderer's method. Made some additional changes inside the method where Iterable<GeographicText> was changed to Iterable<? extends GeographicText>. Changed the BasicGeographicTextRenderer class so that it implements the GeographicTextRenderer interface. - Changed the DeclutteringTextRenderer class to implement the GeographicTextRenderer interface.
Added missing (and useful) TextLayer class that can also be found in the videso3d project's sources (http://code.google.com/p/videso3d). This layer is primarily used to render GeographicText objects which includes user-facing text labels etc.
Changed the TextLayer class to use DeclutteringTextRenderer as its text-renderer. This allows all text that is added to this layer to participate in global decluttering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consolidated the GeographicTextRenderer and DeclutteringTextRenderer classes. The GeographicTextRenderer class was renamed to BasicGeographicTextRenderer so that I could introduce the GeographicTextRenderer interface. The reason for all of this was so that I could use either a normal BasicGeographicTextRenderer or DeclutteringTextRenderer inside the newly added TextLayer class.
I also added a text-offset parameter that is used in both the TextRenderer classes so that we can align the text relative to its geographic position.
The DeclutteringTextRenderer was also modified to include the text-effects found in the BasicGeographicTextRenderer class.