Skip to content

Conversation

@botanical
Copy link
Member

@botanical botanical commented Sep 19, 2025

@botanical botanical marked this pull request as ready for review September 19, 2025 23:17
@botanical botanical changed the title fix: experimenting with stac auth proxy configure_app feat: experimenting with stac auth proxy configure_app Sep 19, 2025
Can we remove the `TenantContext` class in favor of simplicity? It
doesn't seem to be consumed.
Copy link
Member

@alukach alukach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really exciting! Great work everyone 🎉

### What?

Cache collection lookups in the items filter factory

### Why?

When we fetch a tenant's collection to build an items filter, we should
cache that value to reduce pressure on the API

### Testing?

- Relevant testing details
return _TilesApiSettings()


TENANT_ITEM_LINK_TEMPLATES = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer used?

@botanical botanical changed the title feat: experimenting with stac auth proxy configure_app feat(stac)!: experimenting with stac auth proxy configure_app Oct 16, 2025
@botanical botanical requested review from alukach and anayeaye October 16, 2025 18:39
@botanical
Copy link
Member Author

You can view the tenant work on SIT at https://sit.openveda.cloud/api/stac/test-tenant/collections @anayeaye

@alukach
Copy link
Member

alukach commented Oct 21, 2025

At the risk of complicating this feature, I want to verify: is it confirmed that a collection will never be part of multiple tenants? Based on this PR, that seems to be the decision

@botanical
Copy link
Member Author

At the risk of complicating this feature, I want to verify: is it confirmed that a collection will never be part of multiple tenants? Based on this PR, that seems to be the decision

Yes that is correct @alukach

@anayeaye
Copy link
Collaborator

@botanical @alukach do you have any idea where this extra er is coming from in the tenant item links? I don't see anything that would cause it in the middleware or test data 🤔 I am also unaware of any users that would be impacted so I think we can also just open a bug ticket and continue moving forward if nothing comes to mind about why this could happen.

item-map-link-tenant item-map-link

@alukach
Copy link
Member

alukach commented Oct 21, 2025

@anayeaye Good catch. Looks like links to the raster endpoints were being rewritten when they shouldn't have. I believe I fixed it in aa0af07.

Would be great if we could get a test for that but I'm a bit strapped for availability at the moment.

Can someone verify the fix with a deployment?

refactor: eliminate need to pass in root_path into middleware (root path is available on request)
@alukach alukach force-pushed the jt/tenant-filtering-stac-auth-proxy branch from 99ab31d to 6a5556a Compare October 21, 2025 19:17
@anayeaye
Copy link
Collaborator

@alukach @botanical the root path changes seem to be rendering the expected titiler links in test.openveda.cloud/api/stac. Also the stac api referential links all seem to still work as expected for requests with and without tenant prefixes in the stac api url.

@botanical botanical merged commit e9f1c7e into develop Oct 21, 2025
4 checks passed
@botanical botanical deleted the jt/tenant-filtering-stac-auth-proxy branch October 21, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants