[sui-node] post-fork startup and metrics #22862
Open
+233
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
amended-fork-startup
branch
from
5c0769a to
2ba32bc
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
amended-fork-startup
branch
from
2ba32bc to
789e306
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
amended-fork-startup
branch
from
789e306 to
c0772de
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
force-pushed
the
amended-fork-startup
branch
from
c0772de to
b0d34a2
Compare
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
johnjmartin
changed the title
johnjmartin
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
alex-mysten
reviewed
Jul 25, 2025
| @@ -92,6 +92,7 @@ const RANDOMNESS_INJECT_FULL_SIG_ROUTE: &str = "/randomness-inject-full-sig"; | |||
| const GET_TX_COST_ROUTE: &str = "/get-tx-cost"; | |||
| const DUMP_CONSENSUS_TX_COST_ESTIMATES_ROUTE: &str = "/dump-consensus-tx-cost-estimates"; | |||
| const TRAFFIC_CONTROL: &str = "/traffic-control"; | |||
| const CLEAR_CHECKPOINT_FORK_ROUTE: &str = "/clear-checkpoint-fork"; | |||
There was a problem hiding this comment.
Would it make sense to have "/repair-fork" which accepts instructions on how to fix the fork and clears the fork state?
I suppose with my current implementation for recovery operators would need to specify the overrides in YAML, restart the validator, then call /clear-checkpoint-fork.
| @@ -622,6 +622,15 @@ impl CheckpointStore { | |||
| ?local_contents, | |||
| "Local checkpoint fork detected!", | |||
| ); | |||
|
|
|||
| // Record the fork in the database before crashing | |||
| if let Err(e) = self.record_checkpoint_fork_detected( | |||
There was a problem hiding this comment.
What happens when we detect a fork on transaction?
| // Wait for notification from admin API that fork has been cleared | ||
| let mut fork_cleared_rx = checkpoint_fork_cleared_notification.subscribe(); | ||
| tokio::select! { | ||
| _ = fork_cleared_rx.recv() => { |
There was a problem hiding this comment.
Is there a circular dependency with starting the admin server here?
In main.rs, we await start_async to set node_once_cell, then we await node_once_cell to start the admin server. If this blocks, would the admin server ever be started?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today when a fork happens, the sui-node process just crashloops, attempting to start up but forking and panicing repeatedly until the systemd unit or kube controller stops restarting it. This makes it hard for us to know if a node in the network that someone else is running has panicked. all we know is they have stopped pushing us metrics.
This change includes the following:
Test plan
basic unit tests
local cluster tests TODO
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.