Skip to content

[static-ptbs] linkage fixes #22861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2025
Merged

[static-ptbs] linkage fixes #22861

merged 4 commits into from
Jul 25, 2025

Conversation

tzakian
Copy link
Contributor

@tzakian tzakian commented Jul 23, 2025

Description

Bugfixes for the static PTBs

  1. Bottom commit adds a missing trait implementation. Before in the static PTBs this was falling back to a default trait implementation which didn't do the correct thing.
  2. Top commit changes the way we load types. Before we would compute a unified linkage for the type and then load that, however this poses linking issues. Instead we use the way we load types today where we load from the leaves up.

Test plan

CI + replay + new test

@tzakian tzakian requested a review from tnowacki July 23, 2025 23:25
@tzakian tzakian temporarily deployed to sui-typescript-aws-kms-test-env July 23, 2025 23:25 — with GitHub Actions Inactive
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 6:33pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2025 6:33pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2025 6:33pm

@tzakian tzakian changed the title Tzakian/sptb type loading deux [static-ptbs] linkage fixes Jul 23, 2025
@tzakian tzakian merged commit a900c17 into main Jul 25, 2025
69 of 70 checks passed
@tzakian tzakian deleted the tzakian/sptb-type-loading-deux branch July 25, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants