Skip to content

consistency: rpc #22860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jul 27, 2025
Merged

consistency: rpc #22860

merged 0 commits into from
Jul 27, 2025

Conversation

amnn
Copy link
Contributor

@amnn amnn commented Jul 23, 2025

Description

Adds a gRPC service to the consistent store that offers an API for fetching (paginated) objects owned by an address, at a specific checkpoint. The gRPC API is designed such that a Relay Connection in GraphQL could be implemented in terms of it. In later PRs, support will be added for type filtering, fetching shared and immutable objects by type, iterating through all objects by type, regardless of owner kind, and balance queries.

Test plan

$ cargo nextest run -p sui-indexer-alt-consistent-store
$ cargo nextest run -p sui-indexer-alt-e2e-tests \
  --test consistent_store_list_owned_objects_tests

Stack


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@amnn amnn requested a review from a team July 23, 2025 22:59
@amnn amnn self-assigned this Jul 23, 2025
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env July 23, 2025 22:59 — with GitHub Actions Inactive
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ❌ Failed (Inspect) Jul 27, 2025 6:11pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 27, 2025 6:11pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 27, 2025 6:11pm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up needing to de-conflict metric names between services because otherwise they cannot co-exist in the same process (which we need to be able to do now to support transactional testing, and will need to do eventually in a CLI local network set-up).

This will require updating dashboards and alerts, once it reaches production. I'll prepare the changes for those in advance of this change going out to production.

Copy link
Collaborator

@evan-wall-mysten evan-wall-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but someone else should also have a look similar to your other PR.

@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env July 27, 2025 15:53 — with GitHub Actions Inactive
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env July 27, 2025 17:13 — with GitHub Actions Inactive
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env July 27, 2025 17:16 — with GitHub Actions Inactive
@amnn amnn merged commit 8a3f41d into amnn/cos-idx Jul 27, 2025
5 of 8 checks passed
@amnn amnn deleted the amnn/cos-rdr branch July 27, 2025 18:03
@amnn amnn temporarily deployed to sui-typescript-aws-kms-test-env July 27, 2025 18:04 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants