-
Notifications
You must be signed in to change notification settings - Fork 11.6k
consistency: rpc #22860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistency: rpc #22860
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up needing to de-conflict metric names between services because otherwise they cannot co-exist in the same process (which we need to be able to do now to support transactional testing, and will need to do eventually in a CLI local network set-up).
This will require updating dashboards and alerts, once it reaches production. I'll prepare the changes for those in advance of this change going out to production.
crates/sui-indexer-alt-consistent-store/src/rpc/middleware/metrics.rs
Outdated
Show resolved
Hide resolved
crates/sui-indexer-alt-consistent-store/src/rpc/middleware/metrics.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but someone else should also have a look similar to your other PR.
Description
Adds a gRPC service to the consistent store that offers an API for fetching (paginated) objects owned by an address, at a specific checkpoint. The gRPC API is designed such that a Relay Connection in GraphQL could be implemented in terms of it. In later PRs, support will be added for type filtering, fetching shared and immutable objects by type, iterating through all objects by type, regardless of owner kind, and balance queries.
Test plan
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.