Skip to content

[pkg-alt] Reshape transitive deps based on their parent's kind #22856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

manolisliolios
Copy link
Contributor

@manolisliolios manolisliolios commented Jul 23, 2025

Description

We re-shape transitive deps to alter their form based on whether their parent is root or another dep!

Test plan

Wrote unit tests for this.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ❌ Failed (Inspect) Jul 25, 2025 7:59pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 7:59pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 7:59pm

@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 23, 2025 18:24 — with GitHub Actions Inactive
@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 23, 2025 18:35 — with GitHub Actions Inactive
@manolisliolios manolisliolios force-pushed the ml/fix-transitive-deps branch from e69e67a to 16678bd Compare July 24, 2025 15:38
@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 24, 2025 15:38 — with GitHub Actions Inactive
@manolisliolios manolisliolios force-pushed the ml/fix-transitive-deps branch from 16678bd to e87fc04 Compare July 24, 2025 15:39
@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 24, 2025 15:39 — with GitHub Actions Inactive
@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 24, 2025 15:43 — with GitHub Actions Inactive
@manolisliolios manolisliolios temporarily deployed to sui-typescript-aws-kms-test-env July 24, 2025 16:02 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the ml/fix-transitive-deps branch 2 times, most recently from 2e9a8a3 to a23f1dd Compare July 25, 2025 10:55
@mdgeorge4153 mdgeorge4153 self-assigned this Jul 25, 2025
@mdgeorge4153 mdgeorge4153 force-pushed the ml/fix-transitive-deps branch from a23f1dd to 0d52b0c Compare July 25, 2025 12:07
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env July 25, 2025 19:58 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 enabled auto-merge (squash) July 25, 2025 19:59
@mdgeorge4153 mdgeorge4153 merged commit 671beb9 into main Jul 25, 2025
53 of 54 checks passed
@mdgeorge4153 mdgeorge4153 deleted the ml/fix-transitive-deps branch July 25, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants