[ptb] Add error for init on new modules during upgrade #22855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
tnowacki
commented
Jul 23, 2025
Comment on lines
+2169
to
+2185
| if let Some(m) = self | ||
| .compiled_state | ||
| .dep_modules() | ||
| .find(|m| &m.self_id() == id) | ||
| { | ||
| Ok(Some(Cow::Borrowed(m))) | ||
| } else { | ||
| let module = self | ||
| .executor | ||
| .get_object(&ObjectID::from(*id.address())) | ||
| .and_then(|obj| { | ||
| let data = obj.data.try_as_package()?.get_module(id)?; | ||
| let module = CompiledModule::deserialize_with_defaults(data).unwrap(); | ||
| Some(module) | ||
| }) | ||
| .unwrap_or_else(|| panic!("Internal error: Unbound module {}", id)); | ||
| Ok(Some(Cow::Owned(module))) |
There was a problem hiding this comment.
This change was left over from attempting to add upgrade on init. I can make it a separate PR but it feels fine for now?
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
approved these changes
Jul 23, 2025
| @@ -794,6 +794,46 @@ mod checked { | |||
| &modules, | |||
| upgrade_ticket.policy, | |||
| )?; | |||
| if context.protocol_config.check_for_init_during_upgrade() { | |||
| // find newly added modules to the package, | |||
| // and run their init functions (if applicable) | |||
dariorussi
approved these changes
Jul 24, 2025
| @@ -2162,15 +2163,27 @@ impl SuiTestAdapter { | |||
| impl<'a> GetModule for &'a SuiTestAdapter { | |||
| type Error = anyhow::Error; | |||
|
|
|||
| type Item = &'a CompiledModule; | |||
| type Item = Cow<'a, CompiledModule>; | |||
Comment on lines
+831
to
+834
| return Err(ExecutionError::new_with_source( | ||
| ExecutionErrorKind::FeatureNotYetSupported, | ||
| "`init` in new modules on upgrade is not yet supported", | ||
| )); |
There was a problem hiding this comment.
so this is effectively the new error right?
tnowacki
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.